Bug 131626

Summary: Eliminate CachedFrame::m_mousePressNode
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: UI EventsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2014-04-14 11:26:56 PDT
It doesn't make sense to preserve EventHandler::m_mousePressNode in a cached frame (and we don't preserve EventHandler::m_mousePressed anyway, potentially breaking EventHandler invariants). How m_mousePressNode got into CachedFrame was by mechanically combining PageState and PageCache in r20837.
Attachments
proposed patch (4.98 KB, patch)
2014-04-14 11:31 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-04-14 11:31:34 PDT
Created attachment 229294 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-04-14 14:24:31 PDT
Comment on attachment 229294 [details] proposed patch Clearing flags on attachment: 229294 Committed r167267: <http://trac.webkit.org/changeset/167267>
WebKit Commit Bot
Comment 3 2014-04-14 14:24:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.