Bug 131626

Summary:

Eliminate CachedFrame::m_mousePressNode

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

UI Events

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Description Alexey Proskuryakov 2014-04-14 11:26:56 PDT

It doesn't make sense to preserve EventHandler::m_mousePressNode in a cached frame (and we don't preserve EventHandler::m_mousePressed anyway, potentially breaking EventHandler invariants).

How m_mousePressNode got into CachedFrame was by mechanically combining PageState and PageCache in r20837.

Comment 1 Alexey Proskuryakov 2014-04-14 11:31:34 PDT

Created attachment 229294 [details]
proposed patch

Comment 2 WebKit Commit Bot 2014-04-14 14:24:31 PDT

Comment on attachment 229294 [details]
proposed patch

Clearing flags on attachment: 229294

Committed r167267: <http://trac.webkit.org/changeset/167267>

Comment 3 WebKit Commit Bot 2014-04-14 14:24:33 PDT

All reviewed patches have been landed.  Closing bug.