Bug 131614

Summary:

[WinCairo][cURL] Build fix for WinCairo with USE(CURL).

Product:

WebKit

Reporter:

Daewoong Jang <daewoong.jang>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, daewoong.jang

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
WinCairo build fix.	bfulgham: review+, bfulgham: commit-queue+
Updated patch	none

Daewoong Jang

Reported 2014-04-14 07:13:02 PDT

1. While building WinCairo with USE(CURL) instead of USE(SOUP), the compiler experiences errors. 2. cURL's cache system crashes during startup due to use of ascii string without ending NULL.

Attachments
WinCairo build fix. (3.40 KB, patch) 2014-04-14 07:21 PDT, Daewoong Jang	bfulgham: review+ bfulgham: commit-queue+	Details Formatted Diff Diff
Updated patch (3.20 KB, patch) 2014-04-16 09:44 PDT, Daewoong Jang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daewoong Jang

Comment 1 2014-04-14 07:21:45 PDT

Created attachment 229282 [details] WinCairo build fix.

Daewoong Jang

Comment 2 2014-04-16 09:44:11 PDT

Created attachment 229450 [details] Updated patch

Brent Fulgham

Comment 3 2014-04-16 09:44:31 PDT

Comment on attachment 229282 [details] WinCairo build fix. r=me

Brent Fulgham

Comment 4 2014-04-16 09:47:12 PDT

Comment on attachment 229450 [details] Updated patch r=me

WebKit Commit Bot

Comment 5 2014-04-16 10:24:37 PDT

Comment on attachment 229450 [details] Updated patch Clearing flags on attachment: 229450 Committed r167352: <http://trac.webkit.org/changeset/167352>

WebKit Commit Bot

Comment 6 2014-04-16 10:24:39 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.