Bug 131611

Summary:

Make WK(Web)View magnification setters actually use view-relative positions

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	darin: review+

Tim Horton

Reported 2014-04-14 02:58:04 PDT

WKWebView/WKView's setMagnification: and setMagnification:centeredAtPoint: both expose the somewhat bizarre but widespread notion of a scale "origin", which really just translates into the scroll position post-scale. We intended for setMagnification: and setMagnification:centeredAtPoint: to use view-relative points (and points within the view instead of (negative) scroll position) to center the zoom, as those make much more sense as exposed API. <rdar://problem/15965239>

Attachments
patch (5.68 KB, patch) 2014-04-14 03:05 PDT, Tim Horton	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2014-04-14 03:05:37 PDT

Created attachment 229276 [details] patch

Tim Horton

Comment 2 2014-04-14 10:28:39 PDT

http://trac.webkit.org/changeset/167253

Note You need to log in before you can comment on or make changes to this bug.