| Summary: | [sh4] SubImmediates can be used in sh4 LLINT | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Brianceau <jbriance> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren, mark.lam, msaboff, oliver | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Julien Brianceau
2014-04-14 01:02:47 PDT
Created attachment 229272 [details]
Allow use of SubImmediates in sh4 const pool in LLINT.
Comment on attachment 229272 [details] Allow use of SubImmediates in sh4 const pool in LLINT. View in context: https://bugs.webkit.org/attachment.cgi?id=229272&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:747 > + if SH4 > + flushcp # Force constant pool flush to avoid "pcrel too far" link error. > + end I'd be concerned if this proliferates. Ideally, it's be great if the offline backend knows to call flushcp automatically when needed without the LLINT assembly having to explicitly call it like this. For now, since there's is only this one use of flushcp (i.e. here), I'll let it go. Committed r167269: <http://trac.webkit.org/changeset/167269> |