Bug 131572

Summary: [CSS Shapes] Linking stylesheet instead of inline style definition has ruined ShapesRegions test
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Tools / TestsAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128188    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 none

Description Zoltan Horvath 2014-04-11 16:23:40 PDT 
In r167022 I moved the common CSS selectors into RegionsShapes.css, then I linked it into the perf test files, but the measurement results dropped down from about 400ms to 10ms. I realized it's caused by the linked css rule, so I've put the selectors back into every test case, which fixes the test measurements.
Comment 1 Zoltan Horvath 2014-04-11 16:36:20 PDT 
Created attachment 229177 [details]
Patch
Comment 2 Build Bot 2014-04-11 17:28:38 PDT 
Comment on attachment 229177 [details]
Patch

Attachment 229177 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6490103438376960

New failing tests:
compositing/iframes/invisible-nested-iframe-hide.html
Comment 3 Build Bot 2014-04-11 17:28:40 PDT 
Created attachment 229185 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Rob Buis 2014-04-15 10:12:27 PDT 
Comment on attachment 229177 [details]
Patch

Looks good.
Comment 5 WebKit Commit Bot 2014-04-15 10:52:37 PDT 
Comment on attachment 229177 [details]
Patch

Clearing flags on attachment: 229177

Committed r167315: <http://trac.webkit.org/changeset/167315>
Comment 6 WebKit Commit Bot 2014-04-15 10:52:40 PDT 
All reviewed patches have been landed.  Closing bug.