Bug 131564

Summary: Web Replay: consolidate decoding macros used in SerializationMethods
Product: WebKit Reporter: Brian Burg <burg>
Component: WebCore Misc.Assignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, kling, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 131043    
Attachments:
Description Flags
Patch none

Description Brian Burg 2014-04-11 15:24:26 PDT
too many.
Comment 1 Brian Burg 2014-04-11 15:28:47 PDT
Created attachment 229166 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-11 15:30:34 PDT
Attachment 229166 [details] did not pass style-queue:


ERROR: Source/WebCore/replay/SerializationMethods.cpp:130:  _key is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/replay/SerializationMethods.cpp:137:  _key is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-04-11 17:19:51 PDT
Comment on attachment 229166 [details]
Patch

Clearing flags on attachment: 229166

Committed r167173: <http://trac.webkit.org/changeset/167173>
Comment 4 WebKit Commit Bot 2014-04-11 17:19:54 PDT
All reviewed patches have been landed.  Closing bug.