Bug 131564 - Web Replay: consolidate decoding macros used in SerializationMethods
Summary: Web Replay: consolidate decoding macros used in SerializationMethods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks: 131043
  Show dependency treegraph
 
Reported: 2014-04-11 15:24 PDT by Brian Burg
Modified: 2014-04-11 17:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.90 KB, patch)
2014-04-11 15:28 PDT, Brian Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-04-11 15:24:26 PDT
too many.
Comment 1 Brian Burg 2014-04-11 15:28:47 PDT
Created attachment 229166 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-11 15:30:34 PDT
Attachment 229166 [details] did not pass style-queue:


ERROR: Source/WebCore/replay/SerializationMethods.cpp:130:  _key is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/replay/SerializationMethods.cpp:137:  _key is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-04-11 17:19:51 PDT
Comment on attachment 229166 [details]
Patch

Clearing flags on attachment: 229166

Committed r167173: <http://trac.webkit.org/changeset/167173>
Comment 4 WebKit Commit Bot 2014-04-11 17:19:54 PDT
All reviewed patches have been landed.  Closing bug.