Summary: | Aggregate multiple "respondToChangedSelection" calls to one scan for telephone numbers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, commit-queue, rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2014-04-11 13:16:29 PDT
Created attachment 229157 [details]
Patch v1
Comment on attachment 229157 [details] Patch v1 Clearing flags on attachment: 229157 Committed r167148: <http://trac.webkit.org/changeset/167148> All reviewed patches have been landed. Closing bug. Why don't we just do this in editorUIUpdateTimerFired instead of adding a separate timer? (In reply to comment #4) > Why don't we just do this in editorUIUpdateTimerFired instead of adding a separate timer? I saw that there was an early return before the m_editorUIUpdateTimer was started, but knew we needed to do this work every time. Looking at it closer now, the early return was simply a: if (m_editorUIUpdateTimer.isActive()) return; check. I agree the existing timer should be good enough here! (I won't be near a dev environment for a few days, in case anyone else wanted to fix this before then) |