Bug 131556

Summary: [ASan] Build broke because libCompileRuntimeToLLVMIR.a links to libclang_rt.asan_osx_dynamic.dylib
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates, dfarler, ggaren, mmirman, mrowe, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 130523    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2014-04-11 12:17:06 PDT
The fix for Bug 130523 broke ASan builds. When building the static library, libCompileRuntimeToLLVMIR.a, we should not try to link to libclang_rt.asan_osx_dynamic.dylib. Bug 130523: WIP for inlining C++. Added a build target to produce LLVM IR. <https://bugs.webkit.org/show_bug.cgi?id=130523> <http://trac.webkit.org/changeset/167087>
Attachments
Patch v1 (1.35 KB, patch)
2014-04-11 12:24 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-04-11 12:24:09 PDT
Created attachment 229150 [details] Patch v1
Brent Fulgham
Comment 2 2014-04-11 13:39:53 PDT
Comment on attachment 229150 [details] Patch v1 Looks good! r=me
David Kilzer (:ddkilzer)
Comment 3 2014-04-11 13:41:45 PDT
<rdar://problem/16591856>
WebKit Commit Bot
Comment 4 2014-04-11 14:11:56 PDT
Comment on attachment 229150 [details] Patch v1 Clearing flags on attachment: 229150 Committed r167149: <http://trac.webkit.org/changeset/167149>
WebKit Commit Bot
Comment 5 2014-04-11 14:12:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.