Summary: | [GTK] Layout Test media/media-event-listeners.html is failing | ||
---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bugs-noreply, calvaris, chavarria1991, dpino, lmoura, mcatanzaro, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | Other | ||
OS: | Linux | ||
Bug Depends on: | 83704 | ||
Bug Blocks: |
Description
Carlos Alberto Lopez Perez
2014-04-11 10:31:21 PDT
This test is no longer timing out after r178418 (https://trac.webkit.org/changeset/178418). Now, it's failing. Updating expectations on bugs.webkit.org/show_bug.cgi?id=143467. It occasionally passes fine, so I marked it as flaky. It seems this test was passing, although it was marked flaky. However, since r267162 the test is timing out. The failure happened in the following interval: [r267156-r267159] PASS (Expected: PASS FAIL) [r267160-r267161] UNKNOWN r267162 TIMEOUT (Expected: PASS FAIL) I cannot determine the cause within the range [r267160-r267162]. The test result looks the same as the output described in https://bugs.webkit.org/show_bug.cgi?id=131545#c0 Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r267333%20(15940)/media/media-event-listeners-diff.txt --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-event-listeners-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-event-listeners-actual.txt @@ -1,15 +1,2 @@ +FAIL: Timed out waiting for notifyDone to be called -LISTENER(durationchange) -LISTENER(loadedmetadata) -LISTENER(loadeddata) -LISTENER(canplay) -LISTENER(canplaythrough) -LISTENER(play) -LISTENER(playing) -LISTENER(ratechange) -LISTENER(timeupdate) -LISTENER(pause) -LISTENER(ended) -LISTENER(volumechange) -END OF TEST - Update expectations accordingly. It started in r267162, which changed WTR's TestController.cpp: > - WKPageSetMuted(m_mainWebView->page(), true); > + WKPageSetMediaVolume(m_mainWebView->page(), 0); With this change, after setting the video source the player changes the volume from 1 to 0 before playing, which happens to cause the following 'video.volume = 0' become a NOP and the volumechange event ends up not being triggered. Ditto for media/video-volume.html |