Summary: | [GTK] Add support for text-decoration-skip | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | Tools / Tests | Assignee: | Martin Robinson <mrobinson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue, d-r, mmaxfield, mrobinson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Bug Depends on: | 139578 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2014-04-11 08:47:58 PDT
Look like we need an implementation like what was added in: https://bugs.webkit.org/show_bug.cgi?id=128936 Created attachment 243025 [details]
Patch
Comment on attachment 243025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243025&action=review LGTM =) > LayoutTests/platform/gtk/TestExpectations:1949 > webkit.org/b/124507 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ] This was also not fixed? (In reply to comment #3) > Comment on attachment 243025 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243025&action=review > > LGTM =) > > > LayoutTests/platform/gtk/TestExpectations:1949 > > webkit.org/b/124507 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ] > > This was also not fixed? No, I think this is also a subpixel positioning issue. Comment on attachment 243025 [details] Patch Clearing flags on attachment: 243025 Committed r177078: <http://trac.webkit.org/changeset/177078> All reviewed patches have been landed. Closing bug. |