Bug 131540

Summary: [GTK] Add support for text-decoration-skip
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, d-r, mmaxfield, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on: 139578    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2014-04-11 08:47:58 PDT
The following layout test is failing on platform GTK fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-svg.html The failure started to happen on r166902 <http://trac.webkit.org/r166902>. I tested r166901 and the tests passes. From r166902 ahead the test fails. The diff is: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r166911%20%2846234%29/fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-svg-diffs.html
Attachments
Patch (16.87 KB, patch)
2014-12-10 08:36 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-04-11 08:59:49 PDT
Look like we need an implementation like what was added in: https://bugs.webkit.org/show_bug.cgi?id=128936
Martin Robinson
Comment 2 2014-12-10 08:36:50 PST
Created attachment 243025 [details] Patch
Gustavo Noronha (kov)
Comment 3 2014-12-10 10:08:50 PST
Comment on attachment 243025 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243025&action=review LGTM =) > LayoutTests/platform/gtk/TestExpectations:1949 > webkit.org/b/124507 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ] This was also not fixed?
Martin Robinson
Comment 4 2014-12-10 10:29:26 PST
(In reply to comment #3) > Comment on attachment 243025 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243025&action=review > > LGTM =) > > > LayoutTests/platform/gtk/TestExpectations:1949 > > webkit.org/b/124507 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ] > > This was also not fixed? No, I think this is also a subpixel positioning issue.
Martin Robinson
Comment 5 2014-12-10 10:37:06 PST
Comment on attachment 243025 [details] Patch Clearing flags on attachment: 243025 Committed r177078: <http://trac.webkit.org/changeset/177078>
Martin Robinson
Comment 6 2014-12-10 10:37:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.