Summary: | [Mac] Prevent crash when exiting fullscreen mode | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, bfulgham, jer.noble | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Brent Fulgham
2014-04-10 22:04:28 PDT
Created attachment 229107 [details]
Patch
Comment on attachment 229107 [details]
Patch
Nice! r=me.
Created attachment 229138 [details]
I think this resolves the 'real' problem
It was bothering me that we were entering the WKFullScreenWindowController::close method with _fullScreenState != ExitingFullScreen, but _scaleAnimation still non-nil and running an animation. I think the actual fix need to be done 'finishedExitFullScreenAnimation', where we clean up the _fadeAnimation, but don't touch the _scaleAnimation. I still like the initial fix to protect us against leaving a running animation when the window is going away, but I think the 'real' fix is this second patch. Comment on attachment 229138 [details]
I think this resolves the 'real' problem
Updated patch that makes sure we never are in a state where '_fullScreenState != ExitingFullScreen' while we have a running animation.
Comment on attachment 229138 [details]
I think this resolves the 'real' problem
re-r=me.
Committed r167130: <http://trac.webkit.org/changeset/167130> |