Bug 131514

Summary: [Win] Clean up some 64-bit Warnings from Visual Studio Static Analyzer
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cmarcelo, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch thorton: review+, commit-queue: commit-queue-

Brent Fulgham
Reported 2014-04-10 16:36:47 PDT
This patch makes a couple of changes needed for 64-bit support on Windows: 1. Set our Microsoft build settings against Vista for 64-bit. 2. Silence a warning about MEMORY_BASIC_INFORMATION being uninitialized. 3. Silence a warning about deprecated GetTickCount() use
Attachments
Patch (4.16 KB, patch)
2014-04-10 16:38 PDT, Brent Fulgham 		thorton: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-04-10 16:38:57 PDT
Created attachment 229089 [details] Patch
WebKit Commit Bot
Comment 2 2014-04-10 16:56:34 PDT
Comment on attachment 229089 [details] Patch Rejecting attachment 229089 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 229089, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WTF/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5120716332597248
Radar WebKit Bug Importer
Comment 3 2014-04-10 16:59:39 PDT
<rdar://problem/16585906>
Brent Fulgham
Comment 4 2014-04-10 18:02:47 PDT
Committed r167101: <http://trac.webkit.org/changeset/167101>
Note You need to log in before you can comment on or make changes to this bug.