Bug 131503

Summary: Radio buttons are using the wrong sizes and margins
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, webkit-bug-importer, webkit
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jer.noble: review+

Beth Dakin
Reported 2014-04-10 12:00:32 PDT
This is a regression caused by http://trac.webkit.org/changeset/166514 In making checkboxes and radio buttons share code, I accidentally used checkbox metrics in two spots for radio buttons as well. Miraculously, this does not seem to have effected the rendering is any obvious way, but we should still fix it.
Attachments
Patch (1.81 KB, patch)
2014-04-10 15:29 PDT, Beth Dakin 		jer.noble: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-04-10 15:29:58 PDT
Created attachment 229082 [details] Patch
Jer Noble
Comment 2 2014-04-10 15:49:50 PDT
Comment on attachment 229082 [details] Patch Because I can't not have a nit, I'd move the "const int* controlMargins" line down below the zoomedSize.setWidth and zoomedSize.setHeight lines. But r=me. :)
Ahmad Saleem
Comment 3 2022-10-05 15:39:55 PDT
This seems to landed and not backed out: https://github.com/WebKit/WebKit/commit/35462e5d6da95e2a904486feba09884d4bb9cc8e Marking as "RESOLVED FIXED". Thanks!
Radar WebKit Bug Importer
Comment 4 2022-10-05 15:40:19 PDT
<rdar://problem/100827126>
Note You need to log in before you can comment on or make changes to this bug.