Bug 131452

Summary: Avoid Vector copies in RenderGrid::placeItemsOnGrid()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Zan Dobersek 2014-04-09 14:25:26 PDT 
Avoid Vector copies in RenderGrid::placeItemsOnGrid()
Comment 1 Zan Dobersek 2014-04-09 14:27:20 PDT 
Created attachment 228982 [details]
Patch
Comment 2 Sergio Villar Senin 2014-04-10 00:45:07 PDT 
Comment on attachment 228982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228982&action=review

> Source/WebCore/ChangeLog:9
> +        placeAutoMajorAxisItemsOnGrid() methods which take the vectors by value.

There is actually no reason to pass them by value. Let's just use references there. Actually we should use const references as the vectors are not modified at all.
Comment 3 Zan Dobersek 2014-04-10 22:55:57 PDT 
Created attachment 229111 [details]
Patch
Comment 4 Sergio Villar Senin 2014-04-11 01:02:41 PDT 
Comment on attachment 229111 [details]
Patch

Nice changes!

You need to modify the prototypes to fix the build though :)
Comment 5 Zan Dobersek 2014-04-11 01:31:20 PDT 
Created attachment 229118 [details]
Patch for landing

Testing it againg through EWSs.
Comment 6 Zan Dobersek 2014-04-11 10:57:10 PDT 
Comment on attachment 229118 [details]
Patch for landing

Clearing flags on attachment: 229118

Committed r167134: <http://trac.webkit.org/changeset/167134>
Comment 7 Zan Dobersek 2014-04-11 10:57:20 PDT 
All reviewed patches have been landed.  Closing bug.