Bug 131452

Summary: Avoid Vector copies in RenderGrid::placeItemsOnGrid()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Zan Dobersek
Reported 2014-04-09 14:25:26 PDT
Avoid Vector copies in RenderGrid::placeItemsOnGrid()
Attachments
Patch (1.45 KB, patch)
2014-04-09 14:27 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2014-04-10 22:55 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.00 KB, patch)
2014-04-11 01:31 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-04-09 14:27:20 PDT
Created attachment 228982 [details] Patch
Sergio Villar Senin
Comment 2 2014-04-10 00:45:07 PDT
Comment on attachment 228982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228982&action=review > Source/WebCore/ChangeLog:9 > + placeAutoMajorAxisItemsOnGrid() methods which take the vectors by value. There is actually no reason to pass them by value. Let's just use references there. Actually we should use const references as the vectors are not modified at all.
Zan Dobersek
Comment 3 2014-04-10 22:55:57 PDT
Created attachment 229111 [details] Patch
Sergio Villar Senin
Comment 4 2014-04-11 01:02:41 PDT
Comment on attachment 229111 [details] Patch Nice changes! You need to modify the prototypes to fix the build though :)
Zan Dobersek
Comment 5 2014-04-11 01:31:20 PDT
Created attachment 229118 [details] Patch for landing Testing it againg through EWSs.
Zan Dobersek
Comment 6 2014-04-11 10:57:10 PDT
Comment on attachment 229118 [details] Patch for landing Clearing flags on attachment: 229118 Committed r167134: <http://trac.webkit.org/changeset/167134>
Zan Dobersek
Comment 7 2014-04-11 10:57:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.