Don't offer "contact" actions in telephone number menus

• Component: WebKit2
• Status: RESOLVED FIXED

[Brady Eidson]

Don't offer "contact" actions in telephone number menus

<rdar://problem/16556907>

[Brady Eidson]

Created attachment 228981 [details]
Patch v1

[Tim Horton]

Comment on attachment 228981 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:674
> +        if ([[actionObject actionUTI] rangeOfString:@"com.apple.contact."].location == 0)

hasPrefix?

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:678
> +        if ([actionObject isKindOfClass:[getDDSeparatorActionClass() class]])

Isn't it already a Class? Why +class? Same above.

[Tim Horton]

Comment on attachment 228981 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:78
> +@property (readonly) NSString * actionUTI;

I think the star should touch the name (to the right).

[Tim Horton]

Comment on attachment 228981 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=228981&action=review

>> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:78
>> +@property (readonly) NSString * actionUTI;
> 
> I think the star should touch the name (to the right).

Also I think this should be empty and the property should be on a (Details) category? or WKDetails or something I don't remember.

[Brady Eidson]

http://trac.webkit.org/changeset/167034