Bug 131433

Summary: REGRESSION(r166975): [GTK] Page overlays are not drawn anymore after r166975
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: zan
Priority: P2 Keywords: Gtk, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2014-04-09 00:19:05 PDT
WebPage::pageOverlays() and WebPage::drawPageOverlay() have been removed in r166975. We need to use PageOverlayController now.
Attachments
Patch (12.19 KB, patch)
2015-01-27 05:17 PST, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-04-09 00:36:04 PDT
Committed r167006: <http://trac.webkit.org/changeset/167006>
Carlos Garcia Campos
Comment 2 2014-04-23 00:46:07 PDT
It seems webkit-patch land incorrectly closed this bug. This regression is still present.
Carlos Garcia Campos
Comment 3 2015-01-27 05:17:47 PST
Created attachment 245437 [details] Patch This brings back the highlighted areas used by the inspector!
Zan Dobersek
Comment 4 2015-01-27 05:34:07 PST
Comment on attachment 245437 [details] Patch r=me
Carlos Garcia Campos
Comment 5 2015-01-27 08:10:28 PST
Committed r179182: <http://trac.webkit.org/changeset/179182>
Note You need to log in before you can comment on or make changes to this bug.