Bug 131433 - REGRESSION(r166975): [GTK] Page overlays are not drawn anymore after r166975
Summary: REGRESSION(r166975): [GTK] Page overlays are not drawn anymore after r166975
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, Regression
Depends on:
Reported: 2014-04-09 00:19 PDT by Carlos Garcia Campos
Modified: 2015-01-27 08:10 PST (History)
1 user (show)

See Also:

Patch (12.19 KB, patch)
2015-01-27 05:17 PST, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-04-09 00:19:05 PDT
WebPage::pageOverlays() and WebPage::drawPageOverlay() have been removed in r166975. We need to use PageOverlayController now.
Comment 1 Carlos Garcia Campos 2014-04-09 00:36:04 PDT
Committed r167006: <http://trac.webkit.org/changeset/167006>
Comment 2 Carlos Garcia Campos 2014-04-23 00:46:07 PDT
It seems webkit-patch land incorrectly closed this bug. This regression is still present.
Comment 3 Carlos Garcia Campos 2015-01-27 05:17:47 PST
Created attachment 245437 [details]

This brings back the highlighted areas used by the inspector!
Comment 4 Zan Dobersek 2015-01-27 05:34:07 PST
Comment on attachment 245437 [details]

Comment 5 Carlos Garcia Campos 2015-01-27 08:10:28 PST
Committed r179182: <http://trac.webkit.org/changeset/179182>