Bug 131420

Summary: Discern between NaNs that would be safe to tag and NaNs that need some purification before tagging
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: atrick, barraclough, commit-queue, ggaren, juergen, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 131422    
Bug Blocks: 131419    
Attachments:
Description Flags
work in progress
none
almost done
none
the patch
oliver: review+
patch for landing none

Description Filip Pizlo 2014-04-08 20:18:22 PDT 
...
Comment 1 Filip Pizlo 2014-04-15 21:22:56 PDT 
Created attachment 229428 [details]
work in progress
Comment 2 Filip Pizlo 2014-04-16 12:09:51 PDT 
Created attachment 229463 [details]
almost done
Comment 3 Filip Pizlo 2014-04-16 12:44:06 PDT 
Created attachment 229465 [details]
the patch
Comment 4 WebKit Commit Bot 2014-04-16 12:46:54 PDT 
Attachment 229465 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSCJSValue.h:27:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/PureNaN.h:35:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/runtime/PureNaN.h:36:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/runtime/PureNaN.h:37:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 4 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Filip Pizlo 2014-04-16 15:25:03 PDT 
Created attachment 229487 [details]
patch for landing
Comment 6 WebKit Commit Bot 2014-04-16 15:28:05 PDT 
Attachment 229487 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSCJSValue.h:27:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/runtime/PureNaN.h:35:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/runtime/PureNaN.h:36:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/runtime/PureNaN.h:37:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 4 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Filip Pizlo 2014-04-16 15:44:53 PDT 
Landed in http://trac.webkit.org/changeset/167394