| Summary: | Factor tile coverage map into a class | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | kling, simon.fraser, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2014-04-08 19:56:00 PDT
Created attachment 228927 [details]
patch
Created attachment 228928 [details]
make it build on release
Comment on attachment 228928 [details] make it build on release View in context: https://bugs.webkit.org/attachment.cgi?id=228928&action=review > Source/WebCore/platform/graphics/ca/mac/TileCoverageMap.mm:40 > + m_layer.get().setOpacity(0.75); .get(). is ugly; is there a better way? Where is the announcement/documentation about Ref? (In reply to comment #4) > Where is the announcement/documentation about Ref? Andreas? (In reply to comment #3) > (From update of attachment 228928 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228928&action=review > > > Source/WebCore/platform/graphics/ca/mac/TileCoverageMap.mm:40 > > + m_layer.get().setOpacity(0.75); > > .get(). is ugly; is there a better way? There is -> but I think the plan is to remove it as it implies pointer semantics while Ref is supposed to have reference semantics. There is no operator.() so we end up with get(). |