Bug 131417

Summary: Factor tile coverage map into a class
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
make it build on release thorton: review+

Antti Koivisto
Reported 2014-04-08 19:56:00 PDT
Move the map code out from TileController
Attachments
patch (26.98 KB, patch)
2014-04-08 20:01 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
make it build on release (26.86 KB, patch)
2014-04-08 20:18 PDT, Antti Koivisto 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-04-08 20:01:07 PDT
Created attachment 228927 [details] patch
Antti Koivisto
Comment 2 2014-04-08 20:18:48 PDT
Created attachment 228928 [details] make it build on release
Tim Horton
Comment 3 2014-04-08 21:31:40 PDT
Comment on attachment 228928 [details] make it build on release View in context: https://bugs.webkit.org/attachment.cgi?id=228928&action=review > Source/WebCore/platform/graphics/ca/mac/TileCoverageMap.mm:40 > + m_layer.get().setOpacity(0.75); .get(). is ugly; is there a better way?
Simon Fraser (smfr)
Comment 4 2014-04-08 21:38:23 PDT
Where is the announcement/documentation about Ref?
Antti Koivisto
Comment 5 2014-04-08 21:46:19 PDT
(In reply to comment #4) > Where is the announcement/documentation about Ref? Andreas?
Antti Koivisto
Comment 6 2014-04-08 21:51:11 PDT
(In reply to comment #3) > (From update of attachment 228928 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228928&action=review > > > Source/WebCore/platform/graphics/ca/mac/TileCoverageMap.mm:40 > > + m_layer.get().setOpacity(0.75); > > .get(). is ugly; is there a better way? There is -> but I think the plan is to remove it as it implies pointer semantics while Ref is supposed to have reference semantics. There is no operator.() so we end up with get().
Antti Koivisto
Comment 7 2014-04-08 22:02:49 PDT
https://trac.webkit.org/r166997
Note You need to log in before you can comment on or make changes to this bug.