Bug 131400

Summary:

HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, darin, enrica, kling, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

130227

Attachments:

Description	Flags
Fixes the bug	none
Patch for landing	none
Patch for landing 2	none

Description Ryosuke Niwa 2014-04-08 15:19:34 PDT

Right now, aggregatedAttributesForAncestors merges attributes from each ancestor all the way up for each text node.
We should cache the intermediate results on each ancestor along the way.

Comment 1 Ryosuke Niwa 2014-04-08 15:21:58 PDT

Created attachment 228900 [details]
Fixes the bug

Comment 2 Ryosuke Niwa 2014-04-08 16:27:45 PDT

Created attachment 228908 [details]
Patch for landing

Comment 3 Ryosuke Niwa 2014-04-08 16:28:18 PDT

Created attachment 228909 [details]
Patch for landing 2

Comment 4 WebKit Commit Bot 2014-04-08 17:06:36 PDT

Comment on attachment 228909 [details]
Patch for landing 2

Clearing flags on attachment: 228909

Committed r166981: <http://trac.webkit.org/changeset/166981>

Comment 5 WebKit Commit Bot 2014-04-08 17:06:40 PDT

All reviewed patches have been landed.  Closing bug.