Bug 131400

Summary: HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, enrica, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 130227    
Attachments:
Description Flags
Fixes the bug
none
Patch for landing
none
Patch for landing 2 none

Ryosuke Niwa
Reported 2014-04-08 15:19:34 PDT
Right now, aggregatedAttributesForAncestors merges attributes from each ancestor all the way up for each text node. We should cache the intermediate results on each ancestor along the way.
Attachments
Fixes the bug (4.20 KB, patch)
2014-04-08 15:21 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.67 KB, patch)
2014-04-08 16:27 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing 2 (4.24 KB, patch)
2014-04-08 16:28 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-04-08 15:21:58 PDT
Created attachment 228900 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2014-04-08 16:27:45 PDT
Created attachment 228908 [details] Patch for landing
Ryosuke Niwa
Comment 3 2014-04-08 16:28:18 PDT
Created attachment 228909 [details] Patch for landing 2
WebKit Commit Bot
Comment 4 2014-04-08 17:06:36 PDT
Comment on attachment 228909 [details] Patch for landing 2 Clearing flags on attachment: 228909 Committed r166981: <http://trac.webkit.org/changeset/166981>
WebKit Commit Bot
Comment 5 2014-04-08 17:06:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.