Bug 131396

Summary:

Remove lock around atomic string table when web thread is enabled

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

andersca, ap, benjamin, cmarcelo, commit-queue

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none

Description Antti Koivisto 2014-04-08 14:27:20 PDT

It is not needed anymore.

Comment 1 Antti Koivisto 2014-04-08 14:56:12 PDT

Created attachment 228894 [details]
patch

Comment 2 Antti Koivisto 2014-04-08 14:57:02 PDT

Created attachment 228895 [details]
patch

Comment 3 Antti Koivisto 2014-04-08 14:57:19 PDT

<rdar://problem/6330124>

Comment 4 Benjamin Poulain 2014-04-08 14:59:11 PDT

Comment on attachment 228895 [details]
patch

You can also remove the #include for the spin lock.

Comment 5 Antti Koivisto 2014-04-08 15:16:42 PDT

Comment on attachment 228895 [details]
patch

Seems we can't do this yet since WebKit2 UI process side uses WebCore::ResourceRequest which uses AtomicStrings. :(

Comment 6 Benjamin Poulain 2014-04-08 15:25:45 PDT

(In reply to comment #5)
> (From update of attachment 228895 [details])
> Seems we can't do this yet since WebKit2 UI process side uses WebCore::ResourceRequest which uses AtomicStrings. :(

The old lock does not protect that. Neither the refcount nor the flags are thread safe. The lock was a hack for a specific code path into AtomicString.