Bug 131396

Summary: Remove lock around atomic string table when web thread is enabled
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: andersca, ap, benjamin, cmarcelo, commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Antti Koivisto
Reported 2014-04-08 14:27:20 PDT
It is not needed anymore.
Attachments
patch (185.60 KB, patch)
2014-04-08 14:56 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (4.56 KB, patch)
2014-04-08 14:57 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-04-08 14:56:12 PDT
Created attachment 228894 [details] patch
Antti Koivisto
Comment 2 2014-04-08 14:57:02 PDT
Created attachment 228895 [details] patch
Antti Koivisto
Comment 3 2014-04-08 14:57:19 PDT
<rdar://problem/6330124>
Benjamin Poulain
Comment 4 2014-04-08 14:59:11 PDT
Comment on attachment 228895 [details] patch You can also remove the #include for the spin lock.
Antti Koivisto
Comment 5 2014-04-08 15:16:42 PDT
Comment on attachment 228895 [details] patch Seems we can't do this yet since WebKit2 UI process side uses WebCore::ResourceRequest which uses AtomicStrings. :(
Benjamin Poulain
Comment 6 2014-04-08 15:25:45 PDT
(In reply to comment #5) > (From update of attachment 228895 [details]) > Seems we can't do this yet since WebKit2 UI process side uses WebCore::ResourceRequest which uses AtomicStrings. :( The old lock does not protect that. Neither the refcount nor the flags are thread safe. The lock was a hack for a specific code path into AtomicString.
Note You need to log in before you can comment on or make changes to this bug.