Bug 131374

Summary:

[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Add -[WKWebProcessPlugInNodeHandle isTextField]	andersca: review+

Description mitz 2014-04-08 10:56:11 PDT

[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element

Comment 1 mitz 2014-04-08 11:01:55 PDT

Created attachment 228856 [details]
Add -[WKWebProcessPlugInNodeHandle isTextField]

Comment 2 Anders Carlsson 2014-04-08 11:03:21 PDT

Comment on attachment 228856 [details]
Add -[WKWebProcessPlugInNodeHandle isTextField]

View in context: https://bugs.webkit.org/attachment.cgi?id=228856&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:45
> +@property (nonatomic, readonly, getter=isTextField) BOOL textField;

I think we should follow the pattern from JSValue here and make this a method named isTextField instead of a property.

Comment 3 mitz 2014-04-08 11:05:46 PDT

(In reply to comment #2)
> (From update of attachment 228856 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228856&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:45
> > +@property (nonatomic, readonly, getter=isTextField) BOOL textField;
> 
> I think we should follow the pattern from JSValue here and make this a method named isTextField instead of a property.

Done. Committed <http://trac.webkti.org/r166936>.