| Summary: | [CSS Blending] Remove the -webkit- prefix for mix-blend-mode and isolation CSS properties | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ion Rosca <rosca> |
| Component: | CSS | Assignee: | Rik Cabanier <cabanier> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abucur, buildbot, cabanier, commit-queue, dino, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard, rniwa, syoichi, WebkitBugTracker |
| Priority: | P2 | Keywords: | AdobeTracked, WebExposed |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 132680 | ||
| Bug Blocks: | 95614 | ||
| Attachments: | |||
|
Description
Ion Rosca
2014-04-08 02:58:16 PDT
(In reply to comment #0) > Since CSS3 Compositing and Blending spec is now at CR, it might be a good idea to provide unprefixed versions of the blending properties. Specifically: > -webkit-mix-blend-mode => blend-mode > -webkit-isolation => isolation that would be: -webkit-mix-blend-mode => mix-blend-mode Created attachment 229041 [details]
Patch
Comment on attachment 229041 [details] Patch Attachment 229041 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6686597655298048 New failing tests: transitions/blendmode-transitions.html inspector-protocol/layers/layers-blending-compositing-reasons.html fast/repaint/blend-mode-isolate-stacking-context.html Created attachment 229043 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 229041 [details] Patch Attachment 229041 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5052207846129664 New failing tests: transitions/blendmode-transitions.html inspector-protocol/layers/layers-blending-compositing-reasons.html fast/repaint/blend-mode-isolate-stacking-context.html Created attachment 229045 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 229041 [details] Patch Attachment 229041 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6244631964549120 New failing tests: transitions/blendmode-transitions.html inspector-protocol/layers/layers-blending-compositing-reasons.html fast/repaint/blend-mode-isolate-stacking-context.html Created attachment 229046 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 229041 [details] Patch Attachment 229041 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4957122236252160 New failing tests: transitions/blendmode-transitions.html inspector-protocol/layers/layers-blending-compositing-reasons.html fast/repaint/blend-mode-isolate-stacking-context.html Created attachment 229047 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 229305 [details]
Patch
Comment on attachment 229305 [details] Patch Attachment 229305 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4716031360630784 New failing tests: http/tests/navigation/ping-cross-origin.html http/tests/security/dataTransfer-set-data-file-url.html http/tests/navigation/javascriptlink-basic.html http/tests/navigation/redirect-preserves-referrer.html http/tests/navigation/ping-cookie.html http/tests/security/isolatedWorld/userGestureEvents.html http/tests/security/referrer-policy-redirect-link.html http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html http/tests/navigation/document-location-click.html http/tests/security/cookies/third-party-cookie-blocking-user-action.html http/tests/navigation/no-referrer-subframe.html http/tests/navigation/no-referrer-same-window.html http/tests/navigation/ping-same-origin.html http/tests/security/listener/xss-window-onclick-addEventListener.html http/tests/security/listener/xss-window-onclick-shortcut.html http/tests/security/isolatedWorld/events.html http/tests/navigation/javascriptlink-goback.html http/tests/navigation/ping-cross-origin-from-https.html http/tests/navigation/redirect-to-random-url-versus-memory-cache.html http/tests/navigation/no-referrer-target-blank.html http/tests/navigation/no-referrer-reset.html transitions/blendmode-transitions.html http/tests/navigation/document-location-click-timeout.html http/tests/navigation/document-location-mouseover.html http/tests/security/referrer-policy-rel-noreferrer.html http/tests/misc/isindex-with-no-form.html Created attachment 229320 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 229305 [details] Patch Attachment 229305 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5925760439156736 New failing tests: transitions/blendmode-transitions.html Created attachment 229321 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 229305 [details] Patch Attachment 229305 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5159396539629568 New failing tests: transitions/blendmode-transitions.html Created attachment 229325 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 229343 [details]
Patch
Adding the WebExposed keyword because this is an unprefixing patch. Comment on attachment 229343 [details]
Patch
Does the inspector need updating to complete the new name?
Comment on attachment 229343 [details] Patch Clearing flags on attachment: 229343 Committed r167448: <http://trac.webkit.org/changeset/167448> All reviewed patches have been landed. Closing bug. (In reply to comment #20) > (From update of attachment 229343 [details]) > Does the inspector need updating to complete the new name? I don't think so since it doesn't use the css property name anywhere. I'll ask Ion since he's more familiar in this area. |