Bug 131339

Summary: Web Replay: memoize nondeterministic attributes of the Screen interface
Product: WebKit Reporter: Brian Burg <burg>
Component: BindingsAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, commit-queue, esprehn+autocc, joepeck, kling, kondapallykalyan, sam, thorton, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch none

Brian Burg
Reported 2014-04-07 18:43:44 PDT
It seems unlikely that this can be made deterministic by saving/restoring initial main frame size. Instead we can just memoize the attribute values as script accesses them.
Attachments
the patch (6.60 KB, patch)
2014-04-08 15:45 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2014-04-08 15:45:18 PDT
Created attachment 228902 [details] the patch
WebKit Commit Bot
Comment 2 2014-04-08 17:23:13 PDT
Comment on attachment 228902 [details] the patch Clearing flags on attachment: 228902 Committed r166984: <http://trac.webkit.org/changeset/166984>
WebKit Commit Bot
Comment 3 2014-04-08 17:23:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.