Bug 131339

Summary:

Web Replay: memoize nondeterministic attributes of the Screen interface

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Bindings

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, cdumez, commit-queue, esprehn+autocc, joepeck, kling, kondapallykalyan, sam, thorton, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch	none

Description Brian Burg 2014-04-07 18:43:44 PDT

It seems unlikely that this can be made deterministic by saving/restoring initial main frame size. Instead we can just memoize the attribute values as script accesses them.

Comment 1 Brian Burg 2014-04-08 15:45:18 PDT

Created attachment 228902 [details]
the patch

Comment 2 WebKit Commit Bot 2014-04-08 17:23:13 PDT

Comment on attachment 228902 [details]
the patch

Clearing flags on attachment: 228902

Committed r166984: <http://trac.webkit.org/changeset/166984>

Comment 3 WebKit Commit Bot 2014-04-08 17:23:17 PDT

All reviewed patches have been landed.  Closing bug.