Bug 131326

Summary:

Fallback to default storage session when there isn't a valid session ID

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description Daniel Bates 2014-04-07 16:17:37 PDT

We should fallback to the default storage session in WebKit1 and WebKit2 without NetworkProcess when we have a null private browsing session so as to make our behavior consistent with the analogous behavior in WebKit2 with NetworkProcess.

Comment 1 Daniel Bates 2014-04-07 16:17:50 PDT

<rdar://problem/16231679>

Comment 2 Daniel Bates 2014-04-07 16:49:17 PDT

Created attachment 228771 [details]
Patch

Comment 3 Daniel Bates 2014-04-07 16:59:40 PDT

I didn't include a test for this change because it's not obvious to me how to write a test that disables private browsing via WebKit preferences and starts a load before WebKit notifies WebCore of the preference change ([-WebView _preferencesChanged] is called in WebKit1) such that we update the session ID of the page. I am open to suggestions.

Comment 4 Daniel Bates 2014-04-08 09:10:02 PDT

Committed r166928: <http://trac.webkit.org/changeset/166928>