Bug 131324

Summary:

Web Inspector: test helper files should be under LayoutTests/http/tests/inspector/

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

131318

Attachments:

Description	Flags
the patch	none

Description Brian Burg 2014-04-07 16:06:15 PDT

If they are located in LayoutTests/inspector/, then any http tests cannot use the files. LayoutTests/http/tests/ is the file root for the test http server.

Comment 1 Brian Burg 2014-04-07 17:03:29 PDT

Created attachment 228776 [details]
the patch

Comment 2 Joseph Pecoraro 2014-04-07 17:11:03 PDT

Try adding the following to your ~/.gitconfig:

    [diff]
        renames = copies

I think it would make diffs like this significantly smaller and easier to read!

Comment 3 Joseph Pecoraro 2014-04-07 17:13:11 PDT

Comment on attachment 228776 [details]
the patch

r=me

Comment 4 Brian Burg 2014-04-07 17:26:12 PDT

(In reply to comment #2)
> Try adding the following to your ~/.gitconfig:
> 
>     [diff]
>         renames = copies
> 
> I think it would make diffs like this significantly smaller and easier to read!

Will do, thanks. I don't think I copied that to my centralized dot file repo.

Comment 5 WebKit Commit Bot 2014-04-07 17:57:03 PDT

Comment on attachment 228776 [details]
the patch

Clearing flags on attachment: 228776

Committed r166901: <http://trac.webkit.org/changeset/166901>

Comment 6 WebKit Commit Bot 2014-04-07 17:57:06 PDT

All reviewed patches have been landed.  Closing bug.