Bug 131324

Summary: Web Inspector: test helper files should be under LayoutTests/http/tests/inspector/
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 131318    
Attachments:
Description Flags
the patch none

Brian Burg
Reported 2014-04-07 16:06:15 PDT
If they are located in LayoutTests/inspector/, then any http tests cannot use the files. LayoutTests/http/tests/ is the file root for the test http server.
Attachments
the patch (49.61 KB, patch)
2014-04-07 17:03 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2014-04-07 17:03:29 PDT
Created attachment 228776 [details] the patch
Joseph Pecoraro
Comment 2 2014-04-07 17:11:03 PDT
Try adding the following to your ~/.gitconfig: [diff] renames = copies I think it would make diffs like this significantly smaller and easier to read!
Joseph Pecoraro
Comment 3 2014-04-07 17:13:11 PDT
Comment on attachment 228776 [details] the patch r=me
Brian Burg
Comment 4 2014-04-07 17:26:12 PDT
(In reply to comment #2) > Try adding the following to your ~/.gitconfig: > > [diff] > renames = copies > > I think it would make diffs like this significantly smaller and easier to read! Will do, thanks. I don't think I copied that to my centralized dot file repo.
WebKit Commit Bot
Comment 5 2014-04-07 17:57:03 PDT
Comment on attachment 228776 [details] the patch Clearing flags on attachment: 228776 Committed r166901: <http://trac.webkit.org/changeset/166901>
WebKit Commit Bot
Comment 6 2014-04-07 17:57:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.