Bug 131263

Summary: REGRESSION (r163914): Application cache cannot be used in main frame
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Alexey Proskuryakov <ap>
Severity: Normal CC: andersca, beidson, commit-queue, japhet, jeffrey+webkit
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 128557    
Bug Blocks:    
Description Flags
proposed fix
with release build fix none

Description Alexey Proskuryakov 2014-04-04 23:27:20 PDT
We can't look at main frame URL when loading in main frame, because it comes from an unrelated previous page. And when loading into a new page, it's just empty.

Comment 1 Alexey Proskuryakov 2014-04-04 23:27:50 PDT
Regression tests didn't detect this, because they all test appcache in subframes.
Comment 2 Alexey Proskuryakov 2014-04-04 23:32:29 PDT
Created attachment 228660 [details]
proposed fix
Comment 3 Alexey Proskuryakov 2014-04-04 23:37:00 PDT
Created attachment 228661 [details]
with release build fix
Comment 4 Sam Weinig 2014-04-05 16:21:29 PDT
Comment on attachment 228661 [details]
with release build fix

Can we add a regression test so this is caught in the future?
Comment 5 Alexey Proskuryakov 2014-04-05 17:19:32 PDT
Comment on attachment 228661 [details]
with release build fix

I couldn't make a test quickly enough, it would have to be somewhat tricky.
Comment 6 WebKit Commit Bot 2014-04-05 17:48:30 PDT
Comment on attachment 228661 [details]
with release build fix

Clearing flags on attachment: 228661

Committed r166844: <http://trac.webkit.org/changeset/166844>
Comment 7 WebKit Commit Bot 2014-04-05 17:48:33 PDT
All reviewed patches have been landed.  Closing bug.