Summary: | REGRESSION (r163914): Application cache cannot be used in main frame | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Page Loading | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, beidson, commit-queue, japhet, jeffrey+webkit | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 128557 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-04-04 23:27:20 PDT
Regression tests didn't detect this, because they all test appcache in subframes. Created attachment 228660 [details]
proposed fix
Created attachment 228661 [details]
with release build fix
Comment on attachment 228661 [details]
with release build fix
Can we add a regression test so this is caught in the future?
Comment on attachment 228661 [details]
with release build fix
I couldn't make a test quickly enough, it would have to be somewhat tricky.
Comment on attachment 228661 [details] with release build fix Clearing flags on attachment: 228661 Committed r166844: <http://trac.webkit.org/changeset/166844> All reviewed patches have been landed. Closing bug. |