Bug 131251

Summary: Remove bogus ASSERT in -JSVirtualMachine scanObjectGraph
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2014-04-04 18:34:17 PDT
...
Attachments
Patch (2.65 KB, patch)
2014-04-04 20:27 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-04-04 20:27:19 PDT
Created attachment 228650 [details] Patch
Filip Pizlo
Comment 2 2014-04-04 20:54:56 PDT
Comment on attachment 228650 [details] Patch Why was it bogus?
Mark Hahnenberg
Comment 3 2014-04-04 21:20:26 PDT
(In reply to comment #2) > (From update of attachment 228650 [details]) > Why was it bogus? If you look at the other code in JSVirtualMachine, it's all written in such a way where having duplicate entries between an owner and an owned object is ok (e.g. addManagedReference:withOwner:). I think I added this ASSERT before I made it okay to do that and just forgot to remove the ASSERT.
Geoffrey Garen
Comment 4 2014-04-05 10:41:35 PDT
Comment on attachment 228650 [details] Patch r=me
Mark Hahnenberg
Comment 5 2014-04-05 12:26:32 PDT
<rdar://problem/16520725>
WebKit Commit Bot
Comment 6 2014-04-05 12:54:45 PDT
Comment on attachment 228650 [details] Patch Clearing flags on attachment: 228650 Committed r166835: <http://trac.webkit.org/changeset/166835>
WebKit Commit Bot
Comment 7 2014-04-05 12:54:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.