Bug 131235

Summary: Keep track of filtered active attribute/uniform indices per shader program
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, noam, roger_fong, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch dino: review+

Roger Fong
Reported 2014-04-04 11:31:46 PDT
There are a few important methods to be considered here. getUniformLocation getActiveAttrib getActiveUniform getProgramParameter (where you query the number of active uniforms or attributes) These methods should only take into consideration the list of filtered attributes and uniforms per shader program. The logic to filter these attributes and uniforms exists, but we need to move it to the right place.
Attachments
patch (8.95 KB, patch)
2014-04-04 12:13 PDT, Roger Fong 		no flags
DetailsFormatted DiffDiff
patch (8.99 KB, patch)
2014-04-04 14:45 PDT, Roger Fong 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2014-04-04 11:35:52 PDT
<rdar://problem/16371751>
Roger Fong
Comment 2 2014-04-04 12:13:43 PDT
Created attachment 228613 [details] patch
Brent Fulgham
Comment 3 2014-04-04 13:18:27 PDT
Comment on attachment 228613 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228613&action=review Looks good. I think it could be more efficient if we could avoid the double 'find' operation in cases where it is found the first time. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:726 > + const auto& result = m_shaderProgramSymbolCountMap.find(program); Aren't we performing the 'find' twice every time? Maybe this could precede the test for end, and only do the lookup once. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:772 > + const auto& result = m_shaderProgramSymbolCountMap.find(program); Ditto regarding double-lookup.
Roger Fong
Comment 4 2014-04-04 14:31:08 PDT
*** Bug 130477 has been marked as a duplicate of this bug. ***
Roger Fong
Comment 5 2014-04-04 14:45:41 PDT
Created attachment 228617 [details] patch
Roger Fong
Comment 6 2014-04-04 15:10:02 PDT
http://trac.webkit.org/changeset/166803
Note You need to log in before you can comment on or make changes to this bug.