Bug 131228

Summary: [GTK][CMAKE] build-webkit's parameter --no-webkit1 is not honored
Product: WebKit Reporter: Víctor M. Jáquez L. <vjaquez>
Component: WebKitGTKAssignee: Víctor M. Jáquez L. <vjaquez>
Status: RESOLVED WONTFIX    
Severity: Normal CC: bunhere, cgarcia, commit-queue, gyuyoung.kim, mrobinson, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Víctor M. Jáquez L. 2014-04-04 08:33:55 PDT 
When building webkit with

$ build-webkit --gtk --no-webkit1

GtkLaunch and the webkit1 libraries are built.
Comment 1 Víctor M. Jáquez L. 2014-04-04 10:34:23 PDT 
Created attachment 228602 [details]
Patch
Comment 2 Martin Robinson 2014-04-04 10:55:36 PDT 
Comment on attachment 228602 [details]
Patch

WebKit1 supports GTK3, so I'm not sure I understand the patch. We are going to remove WebKit1 soon, so perhaps we can just close this bug and wait for it to go away?
Comment 3 Víctor M. Jáquez L. 2014-04-04 11:14:31 PDT 
(In reply to comment #2)
> (From update of attachment 228602 [details])
> WebKit1 supports GTK3, so I'm not sure I understand the patch. We are going to remove WebKit1 soon, so perhaps we can just close this bug and wait for it to go away?

This patch removes the unconditional compilation of WebKit1 when compiling for GTK3.

Sure, we can close this bug and wait, or commit it and then removes its logic. Just I wanted to spot the issue.
Comment 4 Martin Robinson 2014-04-08 17:47:37 PDT 
WebKit1GTK+ has been removed.