Bug 131200

Summary: check-webkit-style: Improve warnings on Objective-C @property syntax
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, glenn, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-04-03 18:12:57 PDT
It was complaining about space around the '=' operator in: @property (setter=_setFoo) NSString *_foo; It should not. And while we are here, we can encourage: @property (attr) Over: @property(attr)
Attachments
[PATCH] Proposed Fix (3.91 KB, patch)
2014-04-03 18:14 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-04-03 18:14:47 PDT
Created attachment 228569 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2014-04-03 18:57:14 PDT
Comment on attachment 228569 [details] [PATCH] Proposed Fix Clearing flags on attachment: 228569 Committed r166758: <http://trac.webkit.org/changeset/166758>
WebKit Commit Bot
Comment 3 2014-04-03 18:57:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.