Bug 131200 - check-webkit-style: Improve warnings on Objective-C @property syntax
Summary: check-webkit-style: Improve warnings on Objective-C @property syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-03 18:12 PDT by Joseph Pecoraro
Modified: 2014-04-03 18:57 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.91 KB, patch)
2014-04-03 18:14 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-04-03 18:12:57 PDT 
It was complaining about space around the '=' operator in:

    @property (setter=_setFoo) NSString *_foo;

It should not. And while we are here, we can encourage:

    @property (attr)

Over:

    @property(attr)
Comment 1 Joseph Pecoraro 2014-04-03 18:14:47 PDT 
Created attachment 228569 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-04-03 18:57:14 PDT 
Comment on attachment 228569 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 228569

Committed r166758: <http://trac.webkit.org/changeset/166758>
Comment 3 WebKit Commit Bot 2014-04-03 18:57:17 PDT 
All reviewed patches have been landed.  Closing bug.