| Summary: | Use more const refs in ShapeOutsideInfo and some misc cleanup | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||||
| Component: | Layout and Rendering | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, zoltan | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 98664 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Bem Jones-Bey
2014-04-03 16:58:50 PDT
Created attachment 228561 [details]
Patch
The change looks good to me. Comment on attachment 228561 [details]
Patch
r=me
Comment on attachment 228561 [details] Patch Rejecting attachment 228561 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 228561, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: le(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp Hunk #3 FAILED at 132. 1 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp.rej patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dirk Schulze']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5822707933380608 Created attachment 228601 [details]
Patch for landing
Created attachment 228603 [details]
Patch for landing, this time with reviewer properly updated
Comment on attachment 228603 [details] Patch for landing, this time with reviewer properly updated Rejecting attachment 228603 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 228603, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t Parsed 3 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp Hunk #4 FAILED at 159. 1 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp.rej patching file Source/WebCore/rendering/shapes/ShapeOutsideInfo.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5221472641482752 Committed r166797: <http://trac.webkit.org/changeset/166797> |