Summary: | Web Inspector: JSContext inspection provide a way to opt-out of including Native Call Stacks in Exception traces reported to Web Inspector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, ggaren, graouts, joepeck, mhahnenberg, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joseph Pecoraro
2014-04-03 15:46:42 PDT
Created attachment 228552 [details]
[PATCH] Proposed Fix
Attachment 228552 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/API/JSContextPrivate.h:45: Missing spaces around = [whitespace/operators] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 228552 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=228552&action=review r=me > Source/JavaScriptCore/API/JSContextPrivate.h:46 > +@property > +@discussion Set whether or not the native call stack is included when reporting exceptions. Default value is YES. > +*/ > +@property (setter=_setIncludeNativeCallStackWhenReportingExceptions:) BOOL _includeNativeCallStackWhenReportingExceptions NS_AVAILABLE(10_10, 8_0); > + I think the preferred terminology when it comes to verbs is the infinitive: "setIncludes" instead of "setInclude". c.f. – autosaves – setAutosaves: – setSuppressesIncrementalRendering: – suppressesIncrementalRendering Created attachment 228563 [details]
[PATCH] For Landing
Attachment 228563 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/API/JSContextPrivate.h:45: Missing spaces around = [whitespace/operators] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 228563 [details] [PATCH] For Landing Clearing flags on attachment: 228563 Committed r166756: <http://trac.webkit.org/changeset/166756> |