Bug 13117

Summary:

REGRESSION (r14658): Flickering text fields when updating via javascript

Product:

WebKit

Reporter:

Jonathan del Strother <jon>

Component:

New Bugs

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz, mrowe

Priority:

Keywords:

InRadar, Regression

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

URL:

http://bestbefore.tv/flickr.html

Attachments:

Description	Flags
Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout	none
Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout	hyatt: review+

Jonathan del Strother

Reported 2007-03-19 06:30:29 PDT

Text fields often flicker when their value is set with javascript. That is, when their value is changed, the field is cleared to white for a split second, then the actual value is drawn. This is most obvious when they're rapidly updated (see the sample page) but can happen even for a single update. The flicker seems to have been introduced between r14652:14663

Attachments
Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout (2.92 KB, patch) 2007-03-19 08:35 PDT, mitz	no flags	Details Formatted Diff Diff
Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout (2.92 KB, patch) 2007-03-19 08:36 PDT, mitz	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2007-03-19 07:38:27 PDT

I think I know what to do!

mitz

Comment 2 2007-03-19 08:35:19 PDT

Created attachment 13704 [details] Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout The flickering was caused by painting without updating layout first, as a result of -[WebCoreFrameBridge needsLayout] returning NO because the required layout was for a subtree only.

mitz

Comment 3 2007-03-19 08:36:37 PDT

Created attachment 13705 [details] Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout Moved a *.

Maciej Stachowiak

Comment 4 2007-03-19 11:52:26 PDT

<rdar://problem/5072352>

Dave Hyatt

Comment 5 2007-03-19 12:41:29 PDT

Comment on attachment 13705 [details] Change -[WebCoreFrameBridge needsLayout] to consider pending subtree layout r=me

Adele Peterson

Comment 6 2007-03-19 12:46:33 PDT

Committed revision 20324.

Note You need to log in before you can comment on or make changes to this bug.