Bug 131136

Summary: Remove FrameLoadRequest's m_lockHistory member since it's always false
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: Page LoadingAssignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Rowe (bdash)
Reported 2014-04-02 16:13:29 PDT
FrameLoadRequest initialize m_lockHistory to false. Nothing ever calls setLockHistory to alter the value. The one call site that checks for the value being true can be removed.
Attachments
Patch (4.38 KB, patch)
2014-04-02 16:15 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2014-04-02 16:15:42 PDT
Created attachment 228438 [details] Patch
Andreas Kling
Comment 2 2014-04-02 17:15:27 PDT
Comment on attachment 228438 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-04-02 17:56:36 PDT
Comment on attachment 228438 [details] Patch Clearing flags on attachment: 228438 Committed r166685: <http://trac.webkit.org/changeset/166685>
WebKit Commit Bot
Comment 4 2014-04-02 17:56:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.