Bug 131135

Summary: Introduce LockHistory and LockBackForwardList enums to use in place of bools
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: HistoryAssignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Mark Rowe (bdash)
Reported 2014-04-02 15:58:38 PDT
The lockHistory and lockBackForwardList arguments are often passed using literals at the call site. Using multiple consecutive boolean arguments makes it hard to keep track of which is which.
Attachments
Patch (50.47 KB, patch)
2014-04-02 16:11 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Patch (51.32 KB, patch)
2014-04-02 16:27 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2014-04-02 16:11:09 PDT
Created attachment 228437 [details] Patch
WebKit Commit Bot
Comment 2 2014-04-02 16:13:01 PDT
Attachment 228437 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FormSubmission.h:92: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/loader/FrameLoader.h:110: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Rowe (bdash)
Comment 3 2014-04-02 16:27:53 PDT
Created attachment 228444 [details] Patch
WebKit Commit Bot
Comment 4 2014-04-02 16:29:31 PDT
Attachment 228444 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FormSubmission.h:92: The parameter name "event" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/loader/FrameLoader.h:110: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 5 2014-04-02 17:17:15 PDT
Comment on attachment 228444 [details] Patch OK, r=me
WebKit Commit Bot
Comment 6 2014-04-02 17:51:34 PDT
Comment on attachment 228444 [details] Patch Clearing flags on attachment: 228444 Committed r166684: <http://trac.webkit.org/changeset/166684>
WebKit Commit Bot
Comment 7 2014-04-02 17:51:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.