Bug 131125

Summary: [iOS] Expose geolocation provider on the process pool
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebKit2Assignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Dean Jackson
Reported 2014-04-02 13:55:00 PDT
WKProcessPool does not expose a WKGeolocationProviderIOS, which means the WKContentView never triggers the policy request. <rdar://problem/16101582>
Attachments
Patch (4.23 KB, patch)
2014-04-02 13:58 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (2.60 KB, patch)
2014-04-02 16:24 PDT, Dean Jackson 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-04-02 13:58:31 PDT
Created attachment 228426 [details] Patch
Dean Jackson
Comment 2 2014-04-02 14:00:20 PDT
Committed r166663: <http://trac.webkit.org/changeset/166663>
Dean Jackson
Comment 3 2014-04-02 16:24:28 PDT
Reopening to attach new patch.
Dean Jackson
Comment 4 2014-04-02 16:24:32 PDT
Created attachment 228442 [details] Patch
mitz
Comment 5 2014-04-02 16:33:33 PDT
Comment on attachment 228442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228442&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKProcessPoolInternal.h:57 > +@interface WKProcessPool () > @property(readonly) WKGeolocationProviderIOS *_geolocationProvider; I think this can just go into the existing class extension up the file (guarded with TARGET_OS_IPHONE).
Dean Jackson
Comment 6 2014-04-02 16:43:26 PDT
Followup commit r166677
Note You need to log in before you can comment on or make changes to this bug.