Bug 131125

Summary: [iOS] Expose geolocation provider on the process pool
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebKit2Assignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Description Dean Jackson 2014-04-02 13:55:00 PDT
WKProcessPool does not expose a WKGeolocationProviderIOS, which means the WKContentView never triggers the policy request.

<rdar://problem/16101582>
Comment 1 Dean Jackson 2014-04-02 13:58:31 PDT
Created attachment 228426 [details]
Patch
Comment 2 Dean Jackson 2014-04-02 14:00:20 PDT
Committed r166663: <http://trac.webkit.org/changeset/166663>
Comment 3 Dean Jackson 2014-04-02 16:24:28 PDT
Reopening to attach new patch.
Comment 4 Dean Jackson 2014-04-02 16:24:32 PDT
Created attachment 228442 [details]
Patch
Comment 5 mitz 2014-04-02 16:33:33 PDT
Comment on attachment 228442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228442&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessPoolInternal.h:57
> +@interface WKProcessPool ()
>  @property(readonly) WKGeolocationProviderIOS *_geolocationProvider;

I think this can just go into the existing class extension up the file (guarded with TARGET_OS_IPHONE).
Comment 6 Dean Jackson 2014-04-02 16:43:26 PDT
Followup commit r166677