Summary: | Added some more dataLog info for OSR exits | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2014-04-02 13:09:26 PDT
Created attachment 228418 [details]
the patch
Comment on attachment 228418 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=228418&action=review r=me > Source/JavaScriptCore/dfg/DFGOperations.cpp:1044 > + dataLogF(" @ exit #%u (bc#%u, %s) with ", vm->osrExitIndex, debugInfo->bytecodeOffset, exitKindToString(debugInfo->kind)); Don't mix dataLogF and dataLog. Use dataLog. Comment on attachment 228418 [details]
the patch
Will land manually with Michael's suggested changes.
Thanks for the review. Landed in r166662: <http://trac.webkit.org/r166662>. |