Bug 131120

Summary: Added some more dataLog info for OSR exits
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch msaboff: review+

Mark Lam
Reported 2014-04-02 13:09:26 PDT
Adding info about the OSR exit index, the bytecode index of the bytecode that is OSR exiting, and the reason for the OSR exit. This change is for debugging code which only comes into play when we use the --printEachOSRExit option.
Attachments
the patch (3.72 KB, patch)
2014-04-02 13:13 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-04-02 13:13:36 PDT
Created attachment 228418 [details] the patch
Michael Saboff
Comment 2 2014-04-02 13:25:43 PDT
Comment on attachment 228418 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=228418&action=review r=me > Source/JavaScriptCore/dfg/DFGOperations.cpp:1044 > + dataLogF(" @ exit #%u (bc#%u, %s) with ", vm->osrExitIndex, debugInfo->bytecodeOffset, exitKindToString(debugInfo->kind)); Don't mix dataLogF and dataLog. Use dataLog.
Mark Lam
Comment 3 2014-04-02 13:49:34 PDT
Comment on attachment 228418 [details] the patch Will land manually with Michael's suggested changes.
Mark Lam
Comment 4 2014-04-02 13:50:28 PDT
Thanks for the review. Landed in r166662: <http://trac.webkit.org/r166662>.
Note You need to log in before you can comment on or make changes to this bug.