Bug 131110

Summary: [WinCairo] Compile error.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, bfulgham, commit-queue, ossy, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch none

peavo
Reported 2014-04-02 09:02:05 PDT
There's a compilation error in DragImageCairoWin.cpp, since Image::size() now returns a FloatSize instead of an IntSize.
Attachments
Patch (1.27 KB, patch)
2014-04-02 09:06 PDT, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2014-04-02 09:06:17 PDT
Created attachment 228400 [details] Patch
Alex Christensen
Comment 2 2014-04-02 09:28:10 PDT
I was going to do something similar, but I don't have my windows machine to test it. This seems good to me if it works. I'm not following all this float/int stuff too closely, though.
peavo
Comment 3 2014-04-02 10:52:51 PDT
Thanks for looking into this, guys :)
WebKit Commit Bot
Comment 4 2014-04-02 10:55:17 PDT
Comment on attachment 228400 [details] Patch Clearing flags on attachment: 228400 Committed r166652: <http://trac.webkit.org/changeset/166652>
WebKit Commit Bot
Comment 5 2014-04-02 10:55:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.