| Summary: | Split tile grid out from TileController | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, sam, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2014-04-02 05:32:59 PDT
Created attachment 228390 [details]
patch
Comment on attachment 228390 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228390&action=review > Source/WebCore/platform/graphics/ca/mac/TileController.h:2 > + * Copyright (C) 2011-2014 Apple Inc. All rights reserved. We have to explicitly list all copyright years. > We have to explicitly list all copyright years. Nope: https://bugs.webkit.org/show_bug.cgi?id=129065#c3 Comment on attachment 228390 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228390&action=review > Source/WebCore/platform/graphics/ca/mac/TileController.h:88 > + // Public for TileGrid > + bool isInWindow() const { return m_isInWindow; } I would prefer using friend class for this. This broke Mountain Lion and Mavericks tests. E.g., - (tile cache coverage 0, 0 800 x 1024) + (tile cache coverage -2147483648, -2147483648 -2147483648 x -2147483648) Should this be closed? |