Summary: | Remove Settings::maximumDecodedImageSize() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebCore Misc. | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, ddkilzer, esprehn+autocc, gyuyoung.kim, japhet, joepeck, psolanki, yongjun_zhang | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Daniel Bates
2014-04-01 13:49:27 PDT
Created attachment 228319 [details]
Patch
Maybe we should increase the maximum canvas area on iOS? Currently we limit the image buffer of the canvas to 20 MB. Comment on attachment 228319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228319&action=review > Source/WebCore/loader/cache/CachedImage.cpp:400 > + // The image failed to be decoded. Either we need more image data or the image data is malformed. "failed to be decoded" is not grammatical. I suggest "Image decoding failed." > Source/WebCore/loader/cache/CachedImage.cpp:439 > + // The image failed to be decoded; the image data is malformed. Ditto. (In reply to comment #4) > (From update of attachment 228319 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228319&action=review > > > Source/WebCore/loader/cache/CachedImage.cpp:400 > > + // The image failed to be decoded. Either we need more image data or the image data is malformed. > > "failed to be decoded" is not grammatical. I suggest "Image decoding failed." Will fix before landing. > > > Source/WebCore/loader/cache/CachedImage.cpp:439 > > + // The image failed to be decoded; the image data is malformed. > > Ditto. Will fix before landing. Committed r166665: <http://trac.webkit.org/changeset/166665> |