Bug 131057

Summary:

Remove Settings::maximumDecodedImageSize()

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, ddkilzer, esprehn+autocc, gyuyoung.kim, japhet, joepeck, psolanki, yongjun_zhang

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	darin: review+

Daniel Bates

Reported 2014-04-01 13:49:27 PDT

Following up on bug #127029, comment #7, we should remove the setting Settings::maximumDecodedImageSize() and its related logic as this feature has various shortcomings. At the time of writing, the iOS port is the only port that makes use of this setting. That is, the iOS port is the only port that specifies a maximum decoded image size less than the port-independent default size (std::numeric_limits<size_t>::max()). Moreover, this feature is less useful to the iOS port as it has support infrastructure to subsample large images (*). (*) We should look to make this support infrastructure platform-independent.

Attachments
Patch (18.13 KB, patch) 2014-04-01 14:13 PDT, Daniel Bates	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2014-04-01 13:49:41 PDT

<rdar://problem/15626368>

Daniel Bates

Comment 2 2014-04-01 14:13:02 PDT

Created attachment 228319 [details] Patch

Daniel Bates

Comment 3 2014-04-01 14:19:37 PDT

Maybe we should increase the maximum canvas area on iOS? Currently we limit the image buffer of the canvas to 20 MB.

Darin Adler

Comment 4 2014-04-02 09:56:30 PDT

Comment on attachment 228319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228319&action=review > Source/WebCore/loader/cache/CachedImage.cpp:400 > + // The image failed to be decoded. Either we need more image data or the image data is malformed. "failed to be decoded" is not grammatical. I suggest "Image decoding failed." > Source/WebCore/loader/cache/CachedImage.cpp:439 > + // The image failed to be decoded; the image data is malformed. Ditto.

Daniel Bates

Comment 5 2014-04-02 14:05:36 PDT

(In reply to comment #4) > (From update of attachment 228319 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228319&action=review > > > Source/WebCore/loader/cache/CachedImage.cpp:400 > > + // The image failed to be decoded. Either we need more image data or the image data is malformed. > > "failed to be decoded" is not grammatical. I suggest "Image decoding failed." Will fix before landing. > > > Source/WebCore/loader/cache/CachedImage.cpp:439 > > + // The image failed to be decoded; the image data is malformed. > > Ditto. Will fix before landing.

Daniel Bates

Comment 6 2014-04-02 14:10:41 PDT

Committed r166665: <http://trac.webkit.org/changeset/166665>

Note You need to log in before you can comment on or make changes to this bug.