Bug 131042

Summary: [iOS] add missing QuickTime plug-in replacement API
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, glenn, jer.noble, kondapallykalyan, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Updated patch
none
Updated patch
none
Patch for landing none

Description Eric Carlson 2014-04-01 09:26:00 PDT 
Finish replacement plug-in scripting API.
Comment 1 Eric Carlson 2014-04-01 09:46:54 PDT 
Created attachment 228295 [details]
Proposed patch.
Comment 2 WebKit Commit Bot 2014-04-01 09:49:55 PDT 
Attachment 228295 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/MediaPlayer.cpp:644:  Declaration has space between type name and * in NSArray *MediaPlayer  [whitespace/declaration] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2014-04-01 16:07:12 PDT 
Created attachment 228334 [details]
Updated patch
Comment 4 Eric Carlson 2014-04-02 12:03:56 PDT 
Created attachment 228408 [details]
Updated patch
Comment 5 Dean Jackson 2014-04-02 12:30:54 PDT 
Comment on attachment 228408 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228408&action=review

Weird. The patch includes QuickTimePluginReplacement.mm twice.

> Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Maybe +2014?
Comment 6 Eric Carlson 2014-04-02 12:57:15 PDT 
Created attachment 228414 [details]
Patch for landing
Comment 7 Eric Carlson 2014-04-03 08:47:07 PDT 
Committed r166719: https://trac.webkit.org/r166719