Bug 131017

Summary: [EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_async_get API
Product: WebKit Reporter: Joonghun Park <jh718.park>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Joonghun Park 2014-04-01 01:01:59 PDT
For the existing test case for ewk_database_manager_origins_async_get API
1. Fix the memory leak
2. revise variable naming style
3. fix error message caused by duplicated deletion of Ecore_Timer
Comment 1 Joonghun Park 2014-04-01 01:06:30 PDT
Created attachment 228253 [details]
Patch
Comment 2 Ryuan Choi 2014-04-01 01:15:03 PDT
Comment on attachment 228253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228253&action=review

> Source/WebKit2/ChangeLog:4
> +        For the existing test case for ewk_database_manager_origins_async_get API
> +fix the memory leak, revise variable naming style and fix error message caused by duplicated deletion of Ecore_Timer

It's not bug title.
Comment 3 Joonghun Park 2014-04-01 01:20:50 PDT
Created attachment 228254 [details]
Patch
Comment 4 Gyuyoung Kim 2014-04-01 01:54:58 PDT
Comment on attachment 228254 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228254&action=review

> Source/WebKit2/ChangeLog:9
> +        For the existing test case for ewk_database_manager_origins_async_get API

It is hard to understand what are you saying...:(
Comment 5 Joonghun Park 2014-04-01 03:29:20 PDT
Created attachment 228261 [details]
Patch
Comment 6 Gyuyoung Kim 2014-04-01 03:35:33 PDT
Comment on attachment 228261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228261&action=review

> Source/WebKit2/ChangeLog:11
> +        and fix error message caused by duplicated deletion of Ecore_Timer

> For the existing test case about ewk_database_manager_origins_async_get API, fix the memory leak, revise variable naming style and fix error message caused by duplicated deletion of Ecore_Timer

How about below one ?

Fix memory leaks and errors caused by duplication of Ecore_Timer deletion as well as update a naming style of local variable.
Comment 7 Joonghun Park 2014-04-01 03:43:47 PDT
Created attachment 228262 [details]
Patch
Comment 8 Gyuyoung Kim 2014-04-01 03:45:49 PDT
Comment on attachment 228262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228262&action=review

LGTM

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2]Fix and update the existing test case for ewk_database_manager_origins_async_get API

Add a space between "[WK2]" and "Fix" before landing.
Comment 9 Joonghun Park 2014-04-01 03:48:52 PDT
Created attachment 228263 [details]
Patch
Comment 10 Joonghun Park 2014-04-01 04:01:27 PDT
Created attachment 228264 [details]
Patch
Comment 11 Gyuyoung Kim 2014-04-01 04:04:34 PDT
Comment on attachment 228264 [details]
Patch

Do not set r+ if you're not reviewer.
Comment 12 WebKit Commit Bot 2014-04-01 04:39:03 PDT
Comment on attachment 228264 [details]
Patch

Clearing flags on attachment: 228264

Committed r166576: <http://trac.webkit.org/changeset/166576>
Comment 13 WebKit Commit Bot 2014-04-01 04:39:08 PDT
All reviewed patches have been landed.  Closing bug.