Summary: | [EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_async_get API | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joonghun Park <jh718.park> | ||||||||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, sergio | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Joonghun Park
2014-04-01 01:01:59 PDT
Created attachment 228253 [details]
Patch
Comment on attachment 228253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228253&action=review > Source/WebKit2/ChangeLog:4 > + For the existing test case for ewk_database_manager_origins_async_get API > +fix the memory leak, revise variable naming style and fix error message caused by duplicated deletion of Ecore_Timer It's not bug title. Created attachment 228254 [details]
Patch
Comment on attachment 228254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228254&action=review > Source/WebKit2/ChangeLog:9 > + For the existing test case for ewk_database_manager_origins_async_get API It is hard to understand what are you saying...:( Created attachment 228261 [details]
Patch
Comment on attachment 228261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228261&action=review > Source/WebKit2/ChangeLog:11 > + and fix error message caused by duplicated deletion of Ecore_Timer > For the existing test case about ewk_database_manager_origins_async_get API, fix the memory leak, revise variable naming style and fix error message caused by duplicated deletion of Ecore_Timer How about below one ? Fix memory leaks and errors caused by duplication of Ecore_Timer deletion as well as update a naming style of local variable. Created attachment 228262 [details]
Patch
Comment on attachment 228262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228262&action=review LGTM > Source/WebKit2/ChangeLog:3 > + [EFL][WK2]Fix and update the existing test case for ewk_database_manager_origins_async_get API Add a space between "[WK2]" and "Fix" before landing. Created attachment 228263 [details]
Patch
Created attachment 228264 [details]
Patch
Comment on attachment 228264 [details]
Patch
Do not set r+ if you're not reviewer.
Comment on attachment 228264 [details] Patch Clearing flags on attachment: 228264 Committed r166576: <http://trac.webkit.org/changeset/166576> All reviewed patches have been landed. Closing bug. |