Bug 131014

Summary: Prevent unnecessary copies in compareEqual template
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, esprehn+autocc, glenn, kling, koivisto, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2014-04-01 00:41:46 PDT
Prevent unnecessary copies in compareEqual template
Attachments
Patch (1.39 KB, patch)
2014-04-01 00:46 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-04-01 00:46:28 PDT
Created attachment 228250 [details] Patch
Antti Koivisto
Comment 2 2014-04-01 03:08:08 PDT
Comment on attachment 228250 [details] Patch Good spotting. What did this affect?
Zan Dobersek
Comment 3 2014-04-01 08:34:55 PDT
There was no explicit performance issues as such, just an inefficiency that was spotted when looking for unnecessary HashMap copies.
Zan Dobersek
Comment 4 2014-04-01 08:36:11 PDT
Comment on attachment 228250 [details] Patch Clearing flags on attachment: 228250 Committed r166589: <http://trac.webkit.org/changeset/166589>
Zan Dobersek
Comment 5 2014-04-01 08:36:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.