Bug 130983

Summary: Reduce Latched Scroll Test Flakiness
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Updated with rebaselined test output. darin: review+

Brent Fulgham
Reported 2014-03-31 12:56:57 PDT
Try to reduce the flakiness of the new latched scrolling tests by building our NSEvents so that they satisfy the "hasPreciseScrollingDeltas" predicate. The tests were designed to simulate precise scrolling on devices like the Apple Magic Mouse or trackpad, and may behave differently on systems that use a mechanical wheel mouse. Ensure this behavior on all test systems, regardless of installed hardware, by generating the mouse wheel events as though they came from high resolution mouse devices.
Attachments
Patch (3.33 KB, patch)
2014-03-31 13:00 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.34 KB, patch)
2014-03-31 13:13 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Updated with rebaselined test output. (16.92 KB, patch)
2014-03-31 13:35 PDT, Brent Fulgham 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-03-31 13:00:51 PDT
Created attachment 228194 [details] Patch
Brent Fulgham
Comment 2 2014-03-31 13:06:07 PDT
Comment on attachment 228194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228194&action=review > Tools/WebKitTestRunner/mac/EventSenderProxy.mm:476 > + CGEventSetIntegerValueField(cgScrollEvent, kCGScrollWheelEventIsContinuous, 1); Umm. cgScrollEvent.get() of course.
Brent Fulgham
Comment 3 2014-03-31 13:13:54 PDT
Created attachment 228196 [details] Patch
Brent Fulgham
Comment 4 2014-03-31 13:35:44 PDT
Created attachment 228198 [details] Updated with rebaselined test output.
Brent Fulgham
Comment 5 2014-03-31 14:23:21 PDT
Committed r166530: <http://trac.webkit.org/changeset/166530>
Note You need to log in before you can comment on or make changes to this bug.