Summary: | media/track/track-remove-track.html is flaky, crashing and failing | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, clopez, commit-queue, eric.carlson, ggaren, jer.noble | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=142484 | ||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-03-31 09:39:18 PDT
Marked as flaky in <http://trac.webkit.org/r166508>. On GTK this test times out, but if you run it with a high enough timeout it gives this very same failure. I'll update the GTK test expectations for this test to point here also. Created attachment 274777 [details]
Proposed patch.
Comment on attachment 274777 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=274777&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3890 > + Ref<HTMLMediaElement> protect(*this); // Loading and running script can trigger GC. > + ensureUserAgentShadowRoot(); This is not our usual idiom for protect. It's better to add a Ref[Ptr] to a function that needs to use a pointer after an operation that could destroy it. ensureMediaControlsShadowRoot is clearly not such a function, because it doesn't do anything after calling ensureUserAgentShadowRoot(). Comment on attachment 274777 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=274777&action=review > Source/WebCore/ChangeLog:9 > + No new tests, this fixes an existing test. Is the test still marked as flaky or failing in TestExpectations? Created attachment 275050 [details]
Proposed patch.
Attachment 275050 [details] did not pass style-queue:
ERROR: Source/WebCore/html/HTMLMediaElement.cpp:192: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLMediaElement.cpp:193: Multi line control clauses should use braces. [whitespace/braces] [4]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 275050 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=275050&action=review > Source/WebCore/html/HTMLMediaElement.cpp:192 > + #define CASE(actionType) \ Please #undef this at the end. > Source/WebCore/html/HTMLMediaElement.cpp:199 > + CASE(HTMLMediaElementEnums::LoadMediaResource); It's probably better to log without the prefix. > Source/WebCore/html/HTMLMediaElement.cpp:409 > + , m_haveSetupCaptionContainer(false) I think that WebKit style for this is m_haveSetUpCaptionContainer. > Source/WebCore/html/HTMLMediaElement.cpp:3911 > + m_creatingControls = true; Should we ASSERT(!m_creatingControls) here? Created attachment 275091 [details]
Patch for landing.
Comment on attachment 275091 [details] Patch for landing. Clearing flags on attachment: 275091 Committed r198780: <http://trac.webkit.org/changeset/198780> All reviewed patches have been landed. Closing bug. |