Bug 130965

Summary: [CMake] Stop checking for WTF_USE_ICU_UNICODE.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cgarcia, commit-queue, gyuyoung.kim, gyuyoung.kim, mrobinson, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mrobinson: review+, mrobinson: commit-queue-

Description Raphael Kubo da Costa (:rakuco) 2014-03-31 04:09:59 PDT
[CMake] Stop checking for WTF_USE_ICU_UNICODE.
Comment 1 Raphael Kubo da Costa (:rakuco) 2014-03-31 04:11:00 PDT
Created attachment 228172 [details]
Patch
Comment 2 Martin Robinson 2014-03-31 07:11:31 PDT
Comment on attachment 228172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228172&action=review

> Source/JavaScriptCore/CMakeLists.txt:30
> +    "${ICU_INCLUDE_DIRS}"

I'm pretty sure you don't want parenthesis here, since there may be more than one directory.
Comment 3 Raphael Kubo da Costa (:rakuco) 2014-03-31 07:30:34 PDT
(In reply to comment #2)
> (From update of attachment 228172 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228172&action=review
> 
> > Source/JavaScriptCore/CMakeLists.txt:30
> > +    "${ICU_INCLUDE_DIRS}"
> 
> I'm pretty sure you don't want parenthesis here, since there may be more than one directory.

This should be fine; if the variable has a list each item is added as a separate path.
Comment 4 Martin Robinson 2014-03-31 07:35:58 PDT
(In reply to comment #3)

> This should be fine; if the variable has a list each item is added as a separate path.

Won't it evaluate the list as "one two three" instead of "one" "two" "three" though?
Comment 5 Raphael Kubo da Costa (:rakuco) 2014-03-31 07:42:37 PDT
(In reply to comment #4)
> (In reply to comment #3)
> 
> > This should be fine; if the variable has a list each item is added as a separate path.
> 
> Won't it evaluate the list as "one two three" instead of "one" "two" "three" though?

As in "-Ione two three" instead of "-Ione -Itwo -Ithree"? Not really; include_directories("one;two;three") becomes "-Ione -Itwo -Ithree".
Comment 6 Raphael Kubo da Costa (:rakuco) 2014-03-31 08:06:12 PDT
Committed r166503: <http://trac.webkit.org/changeset/166503>
Comment 7 Raphael Kubo da Costa (:rakuco) 2014-03-31 08:06:41 PDT
(In reply to comment #6)
> Committed r166503: <http://trac.webkit.org/changeset/166503>

This is a slightly modified version that does not quote ${ICU_INCLUDE_DIRS}.