Bug 130956

Summary: WebKitPerfMonitor: Sometimes text inside panes overlap
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, kling, koivisto, mjs, slewis, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 130957    
Attachments:
Description Flags
Revamped the pane UI gyuyoung.kim: review+, rniwa: commit-queue+

Ryosuke Niwa
Reported 2014-03-30 21:55:25 PDT
Sometimes build info such as build time, repository names and revision numbers overlap with summary table (the table showing current, baseline, & target). Cleanup the UI to prevent this from happening.
Attachments
Revamped the pane UI (12.21 KB, patch)
2014-03-30 22:21 PDT, Ryosuke Niwa 		gyuyoung.kim: review+
rniwa: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-03-30 22:21:56 PDT
Created attachment 228148 [details] Revamped the pane UI
Gyuyoung Kim
Comment 2 2014-03-30 22:57:04 PDT
Comment on attachment 228148 [details] Revamped the pane UI rs=me.
Zoltan Horvath
Comment 3 2014-03-30 22:58:06 PDT
Comment on attachment 228148 [details] Revamped the pane UI View in context: https://bugs.webkit.org/attachment.cgi?id=228148&action=review Useful change, 2 comments. > Websites/perf.webkit.org/ChangeLog:10 > + reduces the total height of the pane and fits more information per screen capita on the dashboard. typo > Websites/perf.webkit.org/ChangeLog:27 > + (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable. I'll add this to the wiki page for having a place where we can refer if there's a question.
Ryosuke Niwa
Comment 4 2014-03-30 23:39:55 PDT
Committed r166479: <http://trac.webkit.org/changeset/166479>
Note You need to log in before you can comment on or make changes to this bug.